Messages in this thread | | | Date | Wed, 27 Feb 2013 15:18:26 -0800 | From | Anton Vorontsov <> | Subject | Re: [PATCH] power: make goldfish option have a dependency on goldfish |
| |
Hello Paul,
On Wed, Feb 27, 2013 at 01:27:46PM -0500, Paul Gortmaker wrote: > Nearly all the other goldfish peripherals (mtd, keyboard, etc) > have a dependency on the main platform's GOLDFISH Kconfig item, > but this one got skipped, so add it. > > Cc: Anton Vorontsov <cbou@mail.ru> > Cc: David Woodhouse <dwmw2@infradead.org> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com> > ---
Our policy, IIRC, has been quite the opposite: we try to put as little dependencies as possible, letting drivers build on all different kinds of configs/arches/machines. Why? It helps us keep the code in a good shape.
So, unless there are any unresolable build issues with the driver, I believe we should keep it as is.
Thanks,
Anton
> drivers/power/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/power/Kconfig b/drivers/power/Kconfig > index 9e00c38..d314528 100644 > --- a/drivers/power/Kconfig > +++ b/drivers/power/Kconfig > @@ -348,7 +348,7 @@ config AB8500_BM > > config BATTERY_GOLDFISH > tristate "Goldfish battery driver" > - depends on GENERIC_HARDIRQS > + depends on GENERIC_HARDIRQS && GOLDFISH > help > Say Y to enable support for the battery and AC power in the > Goldfish emulator. > -- > 1.8.1.2
| |