Messages in this thread | | | From | Jack Morgenstein <> | Subject | Re: [PATCH v2] IB/mlx4: silence GCC warning | Date | Sun, 24 Feb 2013 14:34:17 +0200 |
| |
On Thursday 21 February 2013 11:02, Paul Bolle wrote:
> diff --git a/drivers/infiniband/hw/mlx4/qp.c b/drivers/infiniband/hw/mlx4/qp.c > index 19e0637..512fde3 100644 > --- a/drivers/infiniband/hw/mlx4/qp.c > +++ b/drivers/infiniband/hw/mlx4/qp.c > @@ -1778,8 +1778,8 @@ static int build_mlx_header(struct mlx4_ib_sqp *sqp, struct ib_send_wr *wr, > } > > vlan = rdma_get_vlan_id(&sgid); > - is_vlan = vlan < 0x1000; > } Nice try! However, this approach does add the line below to processing for an IB port (ETH/RoCE port stays same, more or less). Processing time is therefore increased (at least on the IB side) relative to just living with the warning.
Roland?
> + is_vlan = vlan < 0x1000; <=== Code line added to IB-side processing.
> ib_ud_header_init(send_size, !is_eth, is_eth, is_vlan, is_grh, 0, &sqp->ud_header); > > if (!is_eth) {
-Jack
| |