Messages in this thread | | | Subject | Re: [PATCH] MODSIGN: Fix including certificate twice when the signing_key.x509 already exists | From | joeyli <> | Date | Fri, 22 Feb 2013 16:38:48 +0800 |
| |
Hi David,
Thanks for your review and point out!
於 四,2013-02-21 於 14:16 +0000,David Howells 提到: > > +ifneq ($(shell pwd), $(srctree)) > > How reliable is this, I wonder? > > David >
My current shell is bash, and I tried the '$(shell pwd)' in Makefile works for grab the REAL path when the build path is a symbolic links to kernel source directory. Looks the '$(shell pwd)' in Makefile was call '/bin/pwd' but not 'the shell builtin pwd'.
But, in case the behavior is different between shells, I think used '$(shell /bin/pwd)' will be better for make sure we call /bin/pwd from coreutils.
I will send a second version of this patch, please consider for accept if we need this change.
Thanks a lot! Joey Lee
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |