lkml.org 
[lkml]   [2013]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [BUG bisected]: apei_hest_parse explosion
Date
On Friday, February 22, 2013 03:39:44 PM Thomas Gleixner wrote:
> On Fri, 22 Feb 2013, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> > Subject: ACPI / APEI: Fix crash in apei_hest_parse() for acpi=off
> >
> > After commit 92ef2a2 (ACPI: Change the ordering of PCI root bridge
> > driver registrarion), acpi_hest_init() is never called for acpi=off
> > (acpi_disabled), so hest_disable is not set, but hest_tab is NULL,
> > which causes apei_hest_parse() to crash when it is called from
> > aer_acpi_firmware_first().
> >
> > Fix that by making apei_hest_parse() check if hest_tab is not NULL
> > in addition to checking hest_disable. Also remove the now useless
> > acpi_disabled check from apei_hest_parse().
> >
> > Reported-by: Thomas Gleixner <tglx@linutronix.de>
> > Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Tested-by: Thomas Gleixner <tglx@linutronix.de>

Thanks!



\
 
 \ /
  Last update: 2013-02-22 22:21    [W:0.066 / U:0.576 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site