Messages in this thread | | | Date | Fri, 22 Feb 2013 17:42:34 +0400 | From | Glauber Costa <> | Subject | Re: [PATCH] mm: slab: Verify the nodeid passed to ____cache_alloc_node |
| |
On 02/22/2013 02:07 AM, Aaron Tomlin wrote: > The addition of this BUG_ON should make debugging easier. > While I understand that this code path is "hot", surely > it is better to assert the condition than to wait until > some random NULL pointer dereference or page fault. If the > caller passes an invalid nodeid, at this stage in my opinion > it's already a BUG. If you assert with VM_BUG_ON, it will be active on debugging kernels only, which I believe is better suited for a hotpath.
| |