Messages in this thread | | | Date | Thu, 21 Feb 2013 14:47:59 -0300 | From | Mauro Carvalho Chehab <> | Subject | Re: [PATCH EDACv2 01/12] edac: add support for raw error reports |
| |
Em Thu, 21 Feb 2013 17:08:21 +0100 Borislav Petkov <bp@alien8.de> escreveu:
> On Thu, Feb 21, 2013 at 01:01:25PM -0300, Mauro Carvalho Chehab wrote: > > I did this way to to follow the "one patch per logical change rule". > > The rationale for this patch is to allow doing raw error reports, > > as needed by changeset 06/12. > > Right, but you're adding a new function so why not add the right version > from the get-go? Otherwise the rule above would apply but not for new > code, right?
The rule also applies for both patches.
Except for making everybody's looking on this code to re-read all patches and for me to rebase it again, I can't see any difference between what I posted and your proposal to move patch 10 to the beginning of the changeset.
Anyway, I did it at this separate branch, in order to preserve the previous ghes_v2 (also at the same repository): http://git.infradead.org/users/mchehab/edac.git/shortlog/refs/heads/ghes_v3
Patch 10/12 is now the first patch, and became this one: http://git.infradead.org/users/mchehab/edac.git/commit/c7ef7645544131b0750478d1cf94cdfa945c809d
Patch 01/12 is now the second one: http://git.infradead.org/users/mchehab/edac.git/commit/e7e248304c8ccf02b89e04c3b3b66006b993b5a7
Obviously, the ghes_edac part of 10/12 got fold into this patch: http://git.infradead.org/users/mchehab/edac.git/commit/bf45061af29e585506e8d3bfcda2f2b1e557281c
And a couple other patches got side-affected by this change with trivial conflicts (patches 9/12 and 11/12). Except for this change, v2 and v3 are identical, so I won't re-post it.
Mauro
| |