Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCHv2 vringh 1/3] remoteproc: Add support for vringh (Host vrings) | Date | Thu, 21 Feb 2013 17:07:29 +1030 |
| |
Ohad Ben-Cohen <ohad@wizery.com> writes: > Hi Sjur, > > On Tue, Feb 12, 2013 at 1:49 PM, <sjur.brandeland@stericsson.com> wrote: >> From: Sjur Brændeland <sjur.brandeland@stericsson.com> >> >> Add functions for creating, deleting and kicking host-side virtio rings. >> >> The host ring is not integrated with virtiqueues and cannot be managed >> through virtio-config. > > Is that an inherent design/issue of vringh or just a description of > the current vringh code ?
It's by design. The producer (virtqueue) and consumer (vringh) are two sides of the same coin, but they do different things.
virtqueue is a slightly higher level abstraction which assumes a virtio_device, because every user so far has had one. vringh doesn't, because it's also aimed to underlie vhost.c which doesn't really have one.
> This is possible of course thanks to the abstraction provided by > virtio: remoteproc only implements a set of callbacks which virtio > invokes when needed. > > Do we not want to follow a similar design scheme with vringh ?
Hmm... I clearly jumped the gun, assuming consensus was already reached. I have put these patches *back* into pending-rebases, and they will not be merged this merge window.
Cheers, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |