Messages in this thread | | | Date | Thu, 21 Feb 2013 00:11:10 +0100 (CET) | From | Thomas Gleixner <> | Subject | Re: [PATCH] posix-timer: don't call idr_find() w/ out-of-range ID |
| |
On Wed, 20 Feb 2013, Tejun Heo wrote:
> Hello, Thomas. > > On Thu, Feb 21, 2013 at 12:01:07AM +0100, Thomas Gleixner wrote: > > idr_find() should simply return NULL, if "id < 0". Is it that hard? > > It already does but w/ WARN_ON_ONCE(). The WARN_ON_ONCE() is there > mostly as a transitional precaution. As the previous idr_find() > behavior was extremely weird, just in case someone was depending on > ignoring the msb for example, it would be nice to be able to identify > the ones which are passing in negative ids, at least for a release > cycle or two.
No objection, but please add this to the changelog and the comment.
Thanks,
tglx
| |