Messages in this thread | | | Date | Fri, 15 Feb 2013 21:52:23 +0100 | Subject | Re: [PATCH 3/6] dma: coh901318_lli: avoid unbalanced locking | From | Linus Walleij <> |
| |
On Fri, Feb 15, 2013 at 3:56 PM, Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Fri, Feb 15, 2013 at 4:52 PM, Linus Walleij <linus.walleij@linaro.org> wrote: >> On Tue, Feb 12, 2013 at 11:58 AM, Andy Shevchenko >> <andriy.shevchenko@linux.intel.com> wrote: >> >>> I have not checked the code but there is a possibility that custom pool->lock >>> is not needed at all due to dma_pool contains it's own lock. >> >> Can you please change the description to something like: >> >> "The coh901318_lli allocator releases a lock on the exit path without >> taking it first". > > In v2 (that by fact already applied) I put following description: > > In case the len is 0 we must return without trying to unlock the > lock that was > not locked. > > Does it fit your suggestion?
Sure, acked-by.
Thanks, Linus Walleij
| |