lkml.org 
[lkml]   [2013]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 14/14] tools lib traceevent: Get rid of die() in some string conversion funcitons
Date
On Mon, 9 Dec 2013 11:24:10 -0500, Steven Rostedt wrote:
> On Mon, 9 Dec 2013 14:34:11 +0900
> Namhyung Kim <namhyung@kernel.org> wrote:
>
>> @@ -2231,12 +2238,13 @@ static char *exp_to_str(struct event_filter *filter, struct filter_arg *arg)
>> op = "^";
>> break;
>> default:
>> - die("oops in exp");
>> + break;
>> }
>
> This looks like we silently ignored the warning. Perhaps we should have:
>
> default:
> op = "[ERROR IN EXPRESSION TYPE]";
> break;

Ah, looks better. :)

Thanks,
Namhyung


\
 
 \ /
  Last update: 2013-12-10 03:21    [W:0.647 / U:1.204 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site