| From | Namhyung Kim <> | Subject | Re: [PATCH 14/14] tools lib traceevent: Get rid of die() in some string conversion funcitons | Date | Tue, 10 Dec 2013 10:50:38 +0900 |
| |
On Mon, 9 Dec 2013 11:24:10 -0500, Steven Rostedt wrote: > On Mon, 9 Dec 2013 14:34:11 +0900 > Namhyung Kim <namhyung@kernel.org> wrote: > >> @@ -2231,12 +2238,13 @@ static char *exp_to_str(struct event_filter *filter, struct filter_arg *arg) >> op = "^"; >> break; >> default: >> - die("oops in exp"); >> + break; >> } > > This looks like we silently ignored the warning. Perhaps we should have: > > default: > op = "[ERROR IN EXPRESSION TYPE]"; > break;
Ah, looks better. :)
Thanks, Namhyung
|