lkml.org 
[lkml]   [2013]   [Dec]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 35/41] tile: Replace __get_cpu_var uses
On 12/3/2013 6:33 PM, Christoph Lameter wrote:
> __get_cpu_var() is used for multiple purposes in the kernel source. One of
> them is address calculation via the form &__get_cpu_var(x). This calculates
> the address for the instance of the percpu variable of the current processor
> based on an offset.
>
> [...]
>
> Cc: Chris Metcalf <cmetcalf@tilera.com>
> Signed-off-by: Christoph Lameter <cl@linux.com>

Acked-by: Chris Metcalf <cmetcalf@tilera.com>

Except for a comment typo:

> /*
> * Read the set of maskable interrupts.
> - * We avoid the preemption warning here via __this_cpu_ptr since even
> + * We avoid the preemption warning here via raw_cpu_ptr since even
> * if irqs are already enabled, it's harmless to read the wrong cpu's
> * enabled mask.
> */
> #define arch_local_irqs_enabled() \
> - (*__this_cpu_ptr(&interrupts_enabled_mask))
> + raw_cpu_read(interrupts_enabled_mask)

Should be raw_cpu_read() in the comment.

I assume you are planning to submit these through your own tree, not the arch trees?

--
Chris Metcalf, Tilera Corp.
http://www.tilera.com



\
 
 \ /
  Last update: 2013-12-09 22:21    [W:0.723 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site