lkml.org 
[lkml]   [2013]   [Dec]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] init.h: add missing initcall variants
From
On Sat, Dec 7, 2013 at 4:31 AM, Timur Tabi <timur@tabi.org> wrote:
> On Mon, Dec 2, 2013 at 2:14 PM, Randy Dunlap <rdunlap@infradead.org> wrote:
>> From: Randy Dunlap <rdunlap@infradead.org>
>>
>> Add missing initcall variants when building for loadable modules.
>> This fixes this build error on powerpc allmodconfig:
>>
>> drivers/tty/ehv_bytechan.c: error: type defaults to 'int' in declaration of 'console_initcall' [-Werror=implicit-int]
>
> Acked-by: Timur Tabi <timur@tabi.org>
>
> However, I wonder if it makes sense to have a console_initcall in a
> module at all. Is it possible to load and use a console driver as a
> module?

Of course.

Its use for debugging is limited though, as you obviously won't get output
from it before the module is loaded and the console is registered.

As long as it's e.g. autoloaded from an initramfs, it'll work.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds


\
 
 \ /
  Last update: 2013-12-07 10:21    [W:0.057 / U:1.516 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site