lkml.org 
[lkml]   [2013]   [Dec]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v1 1/5] block: blk-mq: avoid initializing request during its completion
    On Thu, Dec 26 2013, Ming Lei wrote:
    > One problem is that request->start_time/start_time_ns could be
    > set as wrong.
    >
    > Also it is normal to intialize one data structure just after its
    > allocation.
    >
    > So move the initialization out of its completion path.

    It's done that way because of presumed cache hotness on completion,
    since we just touched a lot of the members. Lets just fix the start time
    issue by itself.

    --
    Jens Axboe



    \
     
     \ /
      Last update: 2013-12-31 18:21    [W:2.847 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site