Messages in this thread | | | Date | Tue, 31 Dec 2013 09:38:51 -0700 | From | Jens Axboe <> | Subject | Re: [PATCH v1 1/5] block: blk-mq: avoid initializing request during its completion |
| |
On Thu, Dec 26 2013, Ming Lei wrote: > One problem is that request->start_time/start_time_ns could be > set as wrong. > > Also it is normal to intialize one data structure just after its > allocation. > > So move the initialization out of its completion path.
It's done that way because of presumed cache hotness on completion, since we just touched a lot of the members. Lets just fix the start time issue by itself.
-- Jens Axboe
| |