lkml.org 
[lkml]   [2013]   [Dec]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: 3.12: kernel panic when resuming from suspend to RAM (x86_64)
    Hello Thomas,

    On 12/02/2013 12:20 PM, Thomas Gleixner wrote:
    > On Mon, 2 Dec 2013, Thomas Gleixner wrote:
    >> On Sat, 30 Nov 2013, Francis Moreau wrote:
    >>> Hello Thomas,
    >>>
    >>> Sorry for the delay.
    >>>
    >>> On 11/29/2013 10:02 AM, Thomas Gleixner wrote:
    >>>> On Fri, 29 Nov 2013, Francis Moreau wrote:
    >>>>> Since it seems to be related to rtsx driver or its upper layer, could
    >>>>> the folks involved in this area have a look to this issue please ?
    >>>>
    >>>> I'm not involved, but looking at the debug objects backtrace it's
    >>>> related to the delayed work in rtsx.
    >>>>
    >>>> Does the untested patch below cure the issue?
    >>>>
    >>>
    >>> It seems it does since I can't see the debug object trace anymore
    >>> however Ican see this now:
    >>
    >> <SNIP>
    >>
    >>> So I don't think it completely solve the problem but it's a good start.
    >>
    >> I kinda expected that, but I wanted to confirm my suspicion, that the
    >> interrupt hits after the delayed work is canceled and just requeues it
    >> again, which then leads to an armed timer being freed further down.
    >>
    >> I'm not familiar with that driver and I leave the final fixup to the
    >> driver maintainers. It's enough data for them to figure out the real
    >> solution.
    >
    > Just had a quick look and the obvious solution is to disable the
    > interrupts at the device level _BEFORE_ doing anything else in the
    > teardown path. Updated patch below. That should avoid the nobody cared
    > splat on the other irq line.
    >

    Yes it does.

    Now that you did the hard work, I hope driver's maintainer/developper
    will care about this issue.

    Thank you.


    \
     
     \ /
      Last update: 2013-12-03 09:21    [W:2.648 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site