Messages in this thread | | | Date | Sat, 28 Dec 2013 19:51:59 +0100 | Subject | Re: [PATCH] Add the LED burst trigger | From | Geert Uytterhoeven <> |
| |
On Sat, Dec 28, 2013 at 11:16 AM, Pavel Machek <pavel@ucw.cz> wrote: >> Good idea. >> I have finished but I'll change it to this way soon and test it in next some days. >> >> What the idea about the character to indicate stop? >> >> I mean this patten maybe indicate just once maybe indicate repeatedly until the next patten. >> >> What about "/"? >> If there is a "/" at end then stop it else repeat it? > > Actually, I'd put a do_repeat attribute somewhere instead of using > magic character for automatic repeats. > > And while " " for pause and "#" for light would work. Maybe we chould > do "\0" for pause and "\177" for light... and interpret everything > between as an intensity. That will make it useful for LEDs with > variable intensites, too...
Sysfs is meant to be human-readable/writable, so please use plain ASCII numbers in strings instead.
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |