Messages in this thread | | | Date | Thu, 26 Dec 2013 16:47:50 +0400 | From | Sergei Shtylyov <> | Subject | Re: [PATCH v3.5 18/19] rtlwifi: slight optimization of addr compare |
| |
Hello.
On 26-12-2013 15:41, Ding Tianhong wrote:
> Use possibly more efficient ether_addr_equal_unaligned > instead of memcmp.
> Cc: Larry Finger <Larry.Finger@lwfinger.net> > Cc: Chaoming Li <chaoming_li@realsil.com.cn> > Cc: John W. Linville <linville@tuxdriver.com> > Cc: linux-wireless@vger.kernel.org > Cc: netdev@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Signed-off-by: Weilong Chen <chenweilong@huawei.com> > Signed-off-by: Ding Tianhong <dingtianhong@huawei.com> > --- > drivers/net/wireless/rtlwifi/cam.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)
> diff --git a/drivers/net/wireless/rtlwifi/cam.c b/drivers/net/wireless/rtlwifi/cam.c > index 0e510f7..0276153 100644 > --- a/drivers/net/wireless/rtlwifi/cam.c > +++ b/drivers/net/wireless/rtlwifi/cam.c [...] > @@ -335,7 +335,7 @@ void rtl_cam_del_entry(struct ieee80211_hw *hw, u8 *sta_addr) > addr = rtlpriv->sec.hwsec_cam_sta_addr[i]; > bitmap = (rtlpriv->sec.hwsec_cam_bitmap) >> i; > if (((bitmap & BIT(0)) == BIT(0)) && > - (memcmp(addr, sta_addr, ETH_ALEN) == 0)) { > + (ether_addr_equal_unaligned(addr, sta_addr))) {
It's pointless to enclose function call in parens, again.
WBR, Sergei
| |