lkml.org 
[lkml]   [2013]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] reiserfs:Adding tmpfile support
On Wed, Dec 25, 2013 at 02:39:48PM +0100, Richard Weinberger wrote:
> On Wed, Dec 25, 2013 at 2:23 PM, Fabian Frederick <fabf@skynet.be> wrote:
> > This patch is largely based on reiserfs_create function.
> > -Removing dquot_initialize (cf ext2/tmpfile)
> > -Removing add_entry code.
> > -Adding d_tmpfile generic call.
> >
> > It was not extensively tested; other solutions would
> > be to work with hidden entries or merge
> > creation - tmpfile process.
>
> Is it worth adding new features to a legacy file system like reiserfs?

Having user API parity is always a good thing, especially if it doesn't
require on-disk format changes. Same case as FIEMAP or
SEEK_DATA/SEEK_HOLE to mention some recent features.

That being said this needs to follow them model of ext3/ext3/xfs and
add the inode to the unlink/orphan inode list on tmpfile creation and
move it out on flink.

We'll also need a proper verifier for the expected behaviour, which I
hope we'll get out of the work in progress XFS support.


\
 
 \ /
  Last update: 2013-12-26 10:41    [W:0.026 / U:1.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site