lkml.org 
[lkml]   [2013]   [Dec]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 08/19] ozwpan: slight optimization of addr compare
On 2013/12/25 18:54, Sergei Shtylyov wrote:
> Hello.
>
> On 25-12-2013 7:28, Ding Tianhong wrote:
>
>> Use possibly more efficient ether_addr_equal
>> instead of memcmp.
>
>> Cc: Rupesh Gujare <rupesh.gujare@atmel.com>
>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>> Cc: devel@driverdev.osuosl.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Tan Xiaojun <tanxiaojun@huawei.com>
>> Signed-off-by: Ding Tianhong <dingtianhong@huawei.com>
>> ---
>> drivers/staging/ozwpan/ozcdev.c | 2 +-
>> drivers/staging/ozwpan/ozproto.c | 5 +++--
>> 2 files changed, 4 insertions(+), 3 deletions(-)
>
>> diff --git a/drivers/staging/ozwpan/ozcdev.c b/drivers/staging/ozwpan/ozcdev.c
>> index 6ce0af9..c363f66 100644
>> --- a/drivers/staging/ozwpan/ozcdev.c
>> +++ b/drivers/staging/ozwpan/ozcdev.c
>> @@ -448,7 +448,7 @@ int oz_cdev_start(struct oz_pd *pd, int resume)
>> }
>> spin_lock(&g_cdev.lock);
>> if ((g_cdev.active_pd == NULL) &&
>> - (memcmp(pd->mac_addr, g_cdev.active_addr, ETH_ALEN) == 0)) {
>> + (ether_addr_equal(pd->mac_addr, g_cdev.active_addr))) {
>
> There's no point in enclosing function call into parens.
>
> WBR, Sergei
>

ok, thanks.

Regards
Ding
>
>




\
 
 \ /
  Last update: 2013-12-26 10:01    [W:0.034 / U:0.492 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site