Messages in this thread | | | Date | Thu, 26 Dec 2013 09:53:14 -0800 | From | "H. Peter Anvin" <> | Subject | Re: [PATCH] Use __kernel_long_t in struct mq_attr |
| |
On 12/26/2013 07:54 AM, H.J. Lu wrote: > On Wed, Dec 25, 2013 at 08:58:34AM -0800, H.J. Lu wrote: >> Both x32 and x86-64 use the same struct mq_attr for system calls. But >> x32 long is 32-bit. This patch replaces long with __kernel_long_t in >> struct mq_attr. >> > > Here is the updated patch which uses __kernel_long_t only if > __BITS_PER_LONG == 64. >
That seems wrong in multiple ways... not only does it add more clutter, but it would seem to give the wrong types when __BITS_PER_LONG in userspace is 32.
-hpa
| |