Messages in this thread | | | Date | Sun, 22 Dec 2013 14:22:48 -0500 (EST) | From | Vince Weaver <> | Subject | Re: [PATCH] powercap/rapl: add support for ValleyView Soc |
| |
On Sun, 22 Dec 2013, Rafael J. Wysocki wrote: > On Wednesday, December 11, 2013 02:39:27 PM Jacob Pan wrote:
> > @@ -941,6 +949,7 @@ static void package_power_limit_irq_restore(int package_id) > > static const struct x86_cpu_id rapl_ids[] = { > > { X86_VENDOR_INTEL, 6, 0x2a},/* SNB */ > > { X86_VENDOR_INTEL, 6, 0x2d},/* SNB EP */ > > + { X86_VENDOR_INTEL, 6, 0x37},/* VLV */ > > { X86_VENDOR_INTEL, 6, 0x3a},/* IVB */ > > { X86_VENDOR_INTEL, 6, 0x45},/* HSW */ > > /* TODO: Add more CPU IDs after testing */
This isn't a problem introduced in this patch, but it made me notice it...
Would it really hurt anyone to spell out the architectures here, rather than using obscure 3-letter abbreviations? It's bad enough trying to map the hex model numbers to the decimal ones in /proc/cpuinfo without also having to remember what a VLV is.
Vince
| |