Messages in this thread | | | Date | Mon, 16 Dec 2013 17:47:30 +0100 | From | Michal Hocko <> | Subject | Re: [PATCH 1/2] memcg: fix memcg_size() calculation |
| |
On Sat 14-12-13 12:15:33, Vladimir Davydov wrote: > The mem_cgroup structure contains nr_node_ids pointers to > mem_cgroup_per_node objects, not the objects themselves.
Ouch! This is 2k per node which is wasted. What a shame I haven't noticed this back then when reviewing 45cf7ebd5a033 (memcg: reduce the size of struct memcg 244-fold)
> Signed-off-by: Vladimir Davydov <vdavydov@parallels.com> > Cc: Michal Hocko <mhocko@suse.cz> > Cc: Glauber Costa <glommer@openvz.org> > Cc: Johannes Weiner <hannes@cmpxchg.org> > Cc: Balbir Singh <bsingharora@gmail.com> > Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
Thanks!
> --- > mm/memcontrol.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index bf5e894..7f1a356 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -338,7 +338,7 @@ struct mem_cgroup { > static size_t memcg_size(void) > { > return sizeof(struct mem_cgroup) + > - nr_node_ids * sizeof(struct mem_cgroup_per_node); > + nr_node_ids * sizeof(struct mem_cgroup_per_node *); > } > > /* internal only representation about the status of kmem accounting. */ > -- > 1.7.10.4 >
-- Michal Hocko SUSE Labs
| |