Messages in this thread | | | Date | Thu, 12 Dec 2013 11:11:07 -0500 | From | Tejun Heo <> | Subject | Re: [PATCH v3 11/11] PCI/MSI: Introduce pcim_enable_msi*() family helpers |
| |
On Thu, Dec 12, 2013 at 05:11:01PM +0100, Alexander Gordeev wrote: > On Tue, Dec 10, 2013 at 04:16:02PM -0700, Bjorn Helgaas wrote: > > What's the reason for using the "pcim_" prefix? To me, that suggests that > > this is a "managed" interface in the sense described in > > Documentation/driver-model/devres.txt, where resources are automatically > > deallocated when the driver detaches. But I don't see anything like that > > happening in this patch. > > Oh.. right. What about pci_auto_ prefix to indicate automatic fallback > logic? Or may be even pcia_ ?
I'd vote for pci_auto, one-off single char pre/postfixes usually get pretty confusing.
Thanks.
-- tejun
| |