lkml.org 
[lkml]   [2013]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] wait-simple: Introduce the simple waitqueue implementation
On Thu, 12 Dec 2013, Christoph Hellwig wrote:

> On Wed, Dec 11, 2013 at 08:06:37PM -0500, Paul Gortmaker wrote:
> > From: Thomas Gleixner <tglx@linutronix.de>
> >
> > The wait_queue is a swiss army knife and in most of the cases the
> > full complexity is not needed. Here we provide a slim version, as
> > it lowers memory consumption and runtime overhead.
>
> Might it make more sense to just make the simple one the default and use
> the complex one in the few cases that need it?

Sure.

> It would also be good to enumerate those cases. The wake callbacks come
> to mind, but I guess there are more?

You can convert everything which uses default_wake_function and does
not use the exclusive wait trickery.

Thanks,

tglx


\
 
 \ /
  Last update: 2013-12-12 12:21    [W:0.242 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site