Messages in this thread | | | Date | Wed, 11 Dec 2013 14:47:41 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH 2/2] mm: blk-mq: uses page->list incorrectly |
| |
On Wed, 11 Dec 2013, Dave Hansen wrote:
> > From: Dave Hansen <dave.hansen@linux.intel.com> > > 'struct page' has two list_head fields: 'lru' and 'list'. > Conveniently, they are unioned together. This means that code > can use them interchangably, which gets horribly confusing. > > The blk-mq made the logical decision to try to use page->list. > But, that field was actually introduced just for the slub code. > ->lru is the right field to use outside of slab/slub. > > Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
Acked-by: David Rientjes <rientjes@google.com>
| |