Messages in this thread | | | Date | Tue, 10 Dec 2013 18:37:49 +0000 | From | Lee Jones <> | Subject | Re: [PATCH v3 11/15] mfd: menelaus: Start to use irqdomain |
| |
> > > Introduce an irq_chip and irq_domain for menelaus driver. Following > > > patches will convert uses to traditional request_threaded_irq(). > > > > > > While at that, some better error handling had to be added, so we could > > > free irq descs we allocated. > > > > > > Tested-by: Aaro Koskinen <aaro.koskinen@iki.fi> > > > Signed-off-by: Felipe Balbi <balbi@ti.com> > > > --- > > > drivers/mfd/menelaus.c | 127 ++++++++++++++++++++++++++++++++++++++++++++++--- > > > > <snip> > > > > > + irq_domain_add_legacy(node, MENELAUS_NR_IRQS, irq_base, 0, > > > + &irq_domain_simple_ops, m); > > > > When will this driver become DT compliant? > > when OMAP2 becomes DT-compliant. It still boots with legacy board-file + > platform_data.
Really? Tony, are there any plans to DT the platform?
Felipe, what did you think about using irq_domain_add_simple()?
> > > + m->irq_base = irq_base; > > > + > > > + for (i = irq_base; i < irq_base + MENELAUS_NR_IRQS; i++) { > > > + irq_set_chip_data(i, m); > > > + irq_set_chip_and_handler(i, &menelaus_irq_chip, > > > + handle_simple_irq); > > > + irq_set_nested_thread(i, 1); > > > + set_irq_flags(i, IRQF_VALID); > > > > This assumes that this h/w only exists on ARM platforms. Is that true? > > it was made *only* for Nokia to use on their ARM-only internet tablets.
If the IP is genuinely not reusable, them I'm fine with it.
I see that the Kconfig is setup in the correct way too, so we're good.
-- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |