Messages in this thread | | | From | Tomasz Figa <> | Subject | Re: [PATCH] serial: samsung: move clock deactivation below uart registration | Date | Tue, 10 Dec 2013 14:52:40 +0100 |
| |
Hi Heiko,
On Thursday 05 of December 2013 00:54:38 Heiko Stübner wrote: > Commit 60e93575476f (serial: samsung: enable clock before clearing pending > interrupts during init) added handling of the controller clock during init. > > On most systems this clock is also one of the baud_clock sources and > possibly used by the earlycon and thus already enabled by the bootloader. > > Therefore a gap exists between s3c24xx_serial_init_port disabling the > clock and an attached console reenabling it, making the transition from > earlycon to regular console possibly hang the system - as seen on my > S3C2442 based Freerunner today. > > Therefore move the disabling of the clock from s3c24xx_serial_init_port > below the uart port registration, effectively creating an overlap and > keeping the clock running non-stop if the console wants to grab this port. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > --- > drivers/tty/serial/samsung.c | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-)
Makes sense.
Reviewed-by: Tomasz Figa <t.figa@samsung.com>
Best regards, Tomasz
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |