Messages in this thread | | | Date | Tue, 10 Dec 2013 17:51:47 +0900 | From | Joonsoo Kim <> | Subject | Re: [PATCH v2 4/7] mm/migrate: remove putback_lru_pages, fix comment on putback_movable_pages |
| |
> >@@ -1704,6 +1688,12 @@ int migrate_misplaced_page(struct page *page, struct vm_area_struct *vma, > > nr_remaining = migrate_pages(&migratepages, alloc_misplaced_dst_page, > > node, MIGRATE_ASYNC, MR_NUMA_MISPLACED); > > if (nr_remaining) { > >+ if (!list_empty(&migratepages)) { > >+ list_del(&page->lru); > >+ dec_zone_page_state(page, NR_ISOLATED_ANON + > >+ page_is_file_cache(page)); > >+ putback_lru_page(page); > >+ } > > putback_lru_pages(&migratepages); > > You should remove this line. Otherwise,
Yes, you are right. I will send next version. T_T
> > Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
Thanks.
| |