Messages in this thread | | | Date | Tue, 10 Dec 2013 17:54:53 +0900 | From | Masami Hiramatsu <> | Subject | Re: Re: [PATCH -tip v5 12/18] ftrace/kprobes: Use NOKPROBE_SYMBOL macro in ftrace |
| |
(2013/12/10 2:04), Steven Rostedt wrote: > On Mon, 09 Dec 2013 10:47:46 +0000 > Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote: > > >> --- a/kernel/trace/trace_probe.h >> +++ b/kernel/trace/trace_probe.h >> @@ -124,8 +124,8 @@ struct probe_arg { >> const struct fetch_type *type; /* Type of this argument */ >> }; >> >> -static inline __kprobes void call_fetch(struct fetch_param *fprm, >> - struct pt_regs *regs, void *dest) >> +static inline void call_fetch(struct fetch_param *fprm, >> + struct pt_regs *regs, void *dest) >> { >> return fprm->fn(regs, fprm->data, dest); >> } >> > > Is this OK to be probed? I've had cases where a header "static inline" > was not always inlined. Unless you have "__always_inline" this is not > guaranteed to be inlined.
Ah, right! I need to change it to __always_inline to prevent probing on it.
> > As for the rest of the patch: > > Acked-by: Steven Rostedt <rostedt@goodmis.org>
Thank you! :)
-- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com
| |