lkml.org 
[lkml]   [2013]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Xen-devel] [RFC][PATCH 3/3] timekeeping: Fix potential lost pv notification of time change
>>> On 10.12.13 at 06:09, John Stultz <john.stultz@linaro.org> wrote:
> static cycle_t logarithmic_accumulation(struct timekeeper *tk, cycle_t offset,
> - u32 shift)
> + u32 shift, int *action)

With plain int used here, ...

> @@ -1369,7 +1369,7 @@ static void update_wall_time(void)
> struct timekeeper *tk = &shadow_timekeeper;
> cycle_t offset;
> int shift = 0, maxshift;
> - unsigned int action;
> + unsigned int action = 0;

... and unsigned int used here, ...

> @@ -1404,7 +1404,7 @@ static void update_wall_time(void)
> maxshift = (64 - (ilog2(ntp_tick_length())+1)) - 1;
> shift = min(shift, maxshift);
> while (offset >= tk->cycle_interval) {
> - offset = logarithmic_accumulation(tk, offset, shift);
> + offset = logarithmic_accumulation(tk, offset, shift, &action);

... does this compile without warning for you?

Jan



\
 
 \ /
  Last update: 2013-12-10 10:41    [W:0.035 / U:1.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site