lkml.org 
[lkml]   [2013]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] xen/debugfs: Check debugfs initialization before using it
From
On Tue, Dec 10, 2013 at 2:40 AM, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Mon, Dec 09, 2013 at 09:42:23PM +0800, Ethan Zhao wrote:
>> Greg,
>> I am the man who built a Xen dom0, but couldn't see debugfs
>> directory and files as expected. there is no warning or tip for me to
>> enable the CONFIG_DEBUG_FS=y in .config , it cost me minutes to figure
>> out what's
>> the matter. and I know should check defugfs config and initialization as
>> zswap_debugfs, tracer_debugfs ,rproc_debugfs did. Is it useless ? if
>> it could save me just 1 minute next time ?
>
> So you would want a "warning" showing up for every single part of the
> kernel that uses debugfs for when it isn't enabled? That doesn't make
> too much sense now, does it?

No, It is nice and like sun light when someone is struggling with the
bugs in darkness,
if some tips or warning output to them.

You have forgotten the initial stage you met :)

>
> If you need/want debugfs then enable it in the kernel build, it's not
> that hard, right?

of coz, not hard. and It not so hard to merge it too.

Thanks,
Ethan
>
> greg k-h


\
 
 \ /
  Last update: 2013-12-10 10:41    [W:0.036 / U:0.372 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site