lkml.org 
[lkml]   [2013]   [Nov]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] net: mac80211: tx.c: be sure of 'sdata->vif.type' must be NL80211_IFTYPE_AP when be in NL80211_IFTYPE_AP case
    From
    Date

    > +++ b/net/mac80211/tx.c
    > @@ -1814,8 +1814,9 @@ netdev_tx_t ieee80211_subif_start_xmit(struct sk_buff *skb,
    > break;
    > /* fall through */
    > case NL80211_IFTYPE_AP:
    > - if (sdata->vif.type == NL80211_IFTYPE_AP)
    > - chanctx_conf = rcu_dereference(sdata->vif.chanctx_conf);
    > + if (sdata->vif.type != NL80211_IFTYPE_AP)
    > + goto fail_rcu;
    > + chanctx_conf = rcu_dereference(sdata->vif.chanctx_conf);

    This change is completely wrong.

    johannes



    \
     
     \ /
      Last update: 2013-11-29 17:01    [W:4.031 / U:0.200 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site