lkml.org 
[lkml]   [2013]   [Nov]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] ACPI / PCI / hotplug: Avoid warning when _ADR not present
Date
On Wednesday, November 27, 2013 01:33:09 PM Toshi Kani wrote:
> acpiphp_enumerate_slots() walks ACPI namenamespace under
> a PCI host bridge with callback register_slot().
> register_slot() evaluates _ADR for all the device objects
> and emits a warning message for any error. Some platforms
> have _HID device objects (such as HPET and IPMI), which
> trigger unnecessary warning messages.
>
> This patch avoids emitting a warning message when a target
> device object does not have _ADR.
>
> Signed-off-by: Toshi Kani <toshi.kani@hp.com>
> ---
> Patch is based on Linus's tree (3.13-rc1).

Queued up as a fix for 3.13, thanks!

> ---
> drivers/pci/hotplug/acpiphp_glue.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pci/hotplug/acpiphp_glue.c b/drivers/pci/hotplug/acpiphp_glue.c
> index 1cf605f..438a4d0 100644
> --- a/drivers/pci/hotplug/acpiphp_glue.c
> +++ b/drivers/pci/hotplug/acpiphp_glue.c
> @@ -279,7 +279,9 @@ static acpi_status register_slot(acpi_handle handle, u32 lvl, void *data,
>
> status = acpi_evaluate_integer(handle, "_ADR", NULL, &adr);
> if (ACPI_FAILURE(status)) {
> - acpi_handle_warn(handle, "can't evaluate _ADR (%#x)\n", status);
> + if (status != AE_NOT_FOUND)
> + acpi_handle_warn(handle,
> + "can't evaluate _ADR (%#x)\n", status);
> return AE_OK;
> }
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.


\
 
 \ /
  Last update: 2013-11-28 15:21    [W:0.055 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site