Messages in this thread | | | From | Ramkumar Ramachandra <> | Date | Wed, 27 Nov 2013 15:02:36 +0530 | Subject | Re: [PATCH v2 2/5] perf diff: color the Delta column |
| |
Jiri Olsa wrote: >> diff --git a/tools/perf/builtin-diff.c b/tools/perf/builtin-diff.c >> index 79e0448..84d5f2d 100644 >> --- a/tools/perf/builtin-diff.c >> +++ b/tools/perf/builtin-diff.c >> @@ -769,6 +769,33 @@ static int hpp__entry_baseline(struct hist_entry *he, char *buf, size_t size) >> return ret; >> } >> >> +static int hpp__color_delta(struct perf_hpp_fmt *fmt, >> + struct perf_hpp *hpp, struct hist_entry *he) >> +{ >> + struct diff_hpp_fmt *dfmt = >> + container_of(fmt, struct diff_hpp_fmt, fmt); >> + struct hist_entry *pair = get_pair_fmt(he, dfmt); >> + double percent; >> + char pfmt[20] = " "; >> + >> + if (!pair) >> + goto dummy_print; > > same comment here ^^^ as for previous patch
Hm? The comment on the previous patch pertained to printing the delta if he->dummy was set (ie. if `he' doesn't have any pairs). This statement is analogous to the logic in __hpp__entry_global(): if (!pair), then the next line checking pair->diff.computed will segfault without this check.
| |