Messages in this thread | | | Date | Wed, 27 Nov 2013 16:26:12 +0100 | From | Stefan Agner <> | Subject | Re: [PATCH 1/3] mfd: tps6586x: add version detection |
| |
Am 2013-11-27 15:36, schrieb Lee Jones: <snip> >> Perhaps I should suggest to make TPS6586X_ANY a positive number then, >> as a negative value to me indicates more of an error than a generic >> parameter. I see, its especially confusing since the version is filled using the i2c_smbus_read_byte_data functions return value. The version field is a 8-Bit value according to the data sheet, I could use 0x100 as TPS6586X_ANY identifier.
| |