lkml.org 
[lkml]   [2013]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCHv2] perf tools: Fix tags/TAGS targets rebuilding

* Jiri Olsa <jolsa@redhat.com> wrote:

> On Tue, Nov 26, 2013 at 05:13:16PM +0100, Ingo Molnar wrote:
>
> SNIP
>
> > >
> > > #
> > > # Needed if no target specified:
> > > +# (Except for tags and TAGS targets. The reason is that the
> > > +# Makefile does not treat tags/TAGS as targets but as files
> > > +# and thus won't rebuilt them once they are in place.)
> >
> > s/rebuilt/rebuild
> >
> > Btw., could we perhaps change the targets to 'ctags' and 'etags'
> > instead? (That will make it natural to add 'gtags' in the future,
> > should anyone want that.)
>
> my fingers vote against removing 'make tags' (and cscope)
> dont care much about the rest though.. ;-)

Okay, fair enough, and 'tags/TAGS' targets is also what the main
kernel build system uses - so I concur. For your updated v2 patch:

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

Ingo


\
 
 \ /
  Last update: 2013-11-27 12:41    [W:0.453 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site