lkml.org 
[lkml]   [2013]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3.12 069/116] nfsd4: fix discarded security labels on setattr
    Date
    3.12-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: "J. Bruce Fields" <bfields@redhat.com>

    commit 3378b7f40d79930f0f447a164c7e8fcbe4480e40 upstream.

    Security labels in setattr calls are currently ignored because we forget
    to set label->len.

    Reported-by: Jeff Layton <jlayton@redhat.com>
    Signed-off-by: J. Bruce Fields <bfields@redhat.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/nfsd/nfs4xdr.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/fs/nfsd/nfs4xdr.c
    +++ b/fs/nfsd/nfs4xdr.c
    @@ -411,6 +411,7 @@ nfsd4_decode_fattr(struct nfsd4_compound
    label->data = kzalloc(dummy32 + 1, GFP_KERNEL);
    if (!label->data)
    return nfserr_jukebox;
    + label->len = dummy32;
    defer_free(argp, kfree, label->data);
    memcpy(label->data, buf, dummy32);
    }



    \
     
     \ /
      Last update: 2013-11-27 03:41    [W:4.062 / U:1.168 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site