lkml.org 
[lkml]   [2013]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.2 17/87] wanxl: fix info leak in ioctl
    3.2.53-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Salva Peiró <speiro@ai2.upv.es>

    [ Upstream commit 2b13d06c9584b4eb773f1e80bbaedab9a1c344e1 ]

    The wanxl_ioctl() code fails to initialize the two padding bytes of
    struct sync_serial_settings after the ->loopback member. Add an explicit
    memset(0) before filling the structure to avoid the info leak.

    Signed-off-by: Salva Peiró <speiro@ai2.upv.es>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/wan/wanxl.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/net/wan/wanxl.c b/drivers/net/wan/wanxl.c
    index 44b7071..c643d77 100644
    --- a/drivers/net/wan/wanxl.c
    +++ b/drivers/net/wan/wanxl.c
    @@ -355,6 +355,7 @@ static int wanxl_ioctl(struct net_device *dev, struct ifreq *ifr, int cmd)
    ifr->ifr_settings.size = size; /* data size wanted */
    return -ENOBUFS;
    }
    + memset(&line, 0, sizeof(line));
    line.clock_type = get_status(port)->clocking;
    line.clock_rate = 0;
    line.loopback = 0;
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-11-25 15:21    [W:3.860 / U:0.504 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site