lkml.org 
[lkml]   [2013]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] clocksource: Do not drop unheld reference on device node
    Hello Daniel,

    On Sun, Nov 24, 2013 at 10:28:15PM +0100, Daniel Lezcano wrote:
    > On 11/22/2013 08:22 PM, Uwe Kleine-König wrote:
    > >On Fri, Nov 22, 2013 at 05:31:46PM +0100, Daniel Lezcano wrote:
    > >>On 11/22/2013 05:16 PM, Thierry Reding wrote:
    > >>>On Sat, Oct 19, 2013 at 12:49:48AM +0200, Thierry Reding wrote:
    > >>Yes. Sounds like I missed it.
    > >>
    > >>This regression has been introduced by:
    > >>
    > >>commit 326e31eebe61dc838e031ea16968b2cfb43443e3
    > >>Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > >>Date: Tue Oct 1 11:00:53 2013 +0200
    > >>
    > >> clocksource: Put nodes passed to CLOCKSOURCE_OF_DECLARE
    > >>callbacks centrally
    > >>
    > >> Instead of letting each driver call of_node_put do it centrally in the
    > >> loop that also calls the CLOCKSOURCE_OF_DECLARE callbacks. This is less
    > >> prone to error and also moves getting and putting the references
    > >>into the
    > >> same function.
    > >>
    > >> Consequently all respective of_node_put calls in drivers are removed.
    > >>
    > >> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
    > >> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
    > >> Acked-by: David Brown <davidb@codeaurora.org>
    > >Still all but the hook in clocksource_of_init of this commit was
    > >correct, right? (Well, but this buggy hunk makes the commit log wrong.)
    >
    > I don't understand your comment, can you elaborate ?
    My patch added an of_node_put in clocksource_of_init and dropped several
    of_node_puts in drivers. This thread is about the first being wrong. My
    question was if dropping the others was correct.

    Best regards
    Uwe

    --
    Pengutronix e.K. | Uwe Kleine-König |
    Industrial Linux Solutions | http://www.pengutronix.de/ |
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2013-11-25 08:41    [W:4.222 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site