lkml.org 
[lkml]   [2013]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] Staging:comedi:pcmmio Fixed a printk format in debug section
On Sat, Nov 23, 2013 at 05:05:32PM +0530, Abhishek Sudhakaran wrote:
> Fixed a printk statement in the debug section
> where the string terminator was misplaced.
>
> Signed-off-by: Abhishek Sudhakaran <itzurabhi@gmail.com>
> ---
> drivers/staging/comedi/drivers/pcmmio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcmmio.c b/drivers/staging/comedi/drivers/pcmmio.c
> index 14cee3a..bc1f44c 100644
> --- a/drivers/staging/comedi/drivers/pcmmio.c
> +++ b/drivers/staging/comedi/drivers/pcmmio.c
> @@ -274,7 +274,7 @@ static int pcmmio_dio_insn_bits(struct comedi_device *dev,
> #ifdef DAMMIT_ITS_BROKEN
> /* DEBUG */
> printk
> - (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x,"
> + (KERN_DEBUG "byte %d wmb %02x db %02x offset %02d io %04x",
> " data_in %02x ", byte_no, (unsigned)write_mask_byte,
> (unsigned)data_byte, offset, ioaddr, (unsigned)byte);

Did you build this patch? I think the original code is correct, and
your change will cause an error, right?

greg k-h


\
 
 \ /
  Last update: 2013-11-23 18:41    [W:0.033 / U:0.088 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site