lkml.org 
[lkml]   [2013]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [REVIEW][PATCH 1/4] vfs: Don't allow overwriting mounts in the current mount namespace
    Christoph Hellwig <hch@infradead.org> writes:

    > On Fri, Nov 08, 2013 at 02:17:31PM -0800, Eric W. Biederman wrote:
    >> > Read what you've written a few lines above. The part about target->i_mutex
    >> > being held.
    >>
    >> That works for the rename as unlink case but we don't hold
    >> old_dentry->d_inode->i_mutex which is what is needed to prevent a mount
    >> on the dentry we are renaming.
    >
    > It will be held in 3.13.

    Only for files, not for directories. And none of those locks turns out
    to be good enough today to prevent the races between mount and rename.
    With the result that when mount returns your mount point could be
    located just about anywhere, and that is just considering renames of the
    actual mountpoint itself.

    Eric


    \
     
     \ /
      Last update: 2013-11-21 22:21    [W:3.698 / U:1.180 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site