lkml.org 
[lkml]   [2013]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [RFC][PATCH v5 06/14] sched: create a new field with available capacity
From
On 12 November 2013 11:34, Peter Zijlstra <peterz@infradead.org> wrote:
> On Fri, Oct 18, 2013 at 01:52:19PM +0200, Vincent Guittot wrote:
>> This new field power_available reflects the available capacity of a CPU
>> unlike the cpu_power which reflects the current capacity.
>
>> - sdg->sgp->power_orig = sdg->sgp->power = power;
>> + sdg->sgp->power_orig = sdg->sgp->power_available = available;
>> + sdg->sgp->power = power;
>
> This patch leaves me confused as to power_available vs power_orig and
> the Changelog doesn't really clarify anything much at all.

Ok, i will add more details in the changelog
power_ori can only modified for SMT purpose otherwise it stays to 1024
whereas power_available take into account the modification that has
been done by the platform.

I can probably re-factor that and merge power_ori and power_available.
At now, arch_scale_smt_power and arch_scale_freq_power are not used
simultaneously by an architecture so I can probably move the returned
value of arch_scale_freq_power into the power_ori. This would even
make more sense regarding the current use of it.


\
 
 \ /
  Last update: 2013-11-12 12:21    [W:0.299 / U:25.436 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site