Messages in this thread | | | Date | Wed, 09 Oct 2013 15:39:50 +0900 | From | "sangjung.woo" <> | Subject | Re: [PATCH] rtc: rtc-puv3: use dev_dbg() instead of pr_debug() |
| |
On 10/09/2013 03:20 PM, Joe Perches wrote: > On Wed, 2013-10-09 at 14:49 +0900, Sangjung Woo wrote: >> Because dev_*() are used along with pr_debug() function in this code, >> the debug message is not tidy. This patch converts from pr_debug() to >> dev_dbg() since dev_*() are encouraged to use in device driver code. > [] >> diff --git a/drivers/rtc/rtc-puv3.c b/drivers/rtc/rtc-puv3.c > [] >> @@ -57,7 +57,7 @@ static void puv3_rtc_setaie(int to) >> { >> unsigned int tmp; >> >> - pr_debug("%s: aie=%d\n", __func__, to); >> + dev_dbg(dev, "%s: aie=%d\n", __func__, to); > Does this compile? > > Oops! I did not add my local modification into the patch. The function parameters should be modified as below.
-static void puv3_rtc_setaie(int to) +static void puv3_rtc_setaie(struct device *dev, int to)
I will send the new one. Thank you for your good review.
Cheers, Sangjung
| |