Messages in this thread | | | From | Zhan Jianyu <> | Date | Tue, 8 Oct 2013 11:27:57 +0800 | Subject | Re: [PATCH 07/14] vrange: Purge volatile pages when memory is tight |
| |
On Thu, Oct 3, 2013 at 8:51 AM, John Stultz <john.stultz@linaro.org> wrote: > static inline int page_referenced(struct page *page, int is_locked, > struct mem_cgroup *memcg, > - unsigned long *vm_flags) > + unsigned long *vm_flags, > + int *is_vrange) > { > *vm_flags = 0; > + *is_vrange = 0; > return 0; > }
I don't know if it is appropriate to add a parameter in such a core function for an optional functionality. Maybe the is_vrange flag should be squashed into the vm_flags ? I am not sure .
--
Regards, Zhan Jianyu
| |