Messages in this thread | | | Date | Thu, 31 Oct 2013 09:22:30 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH -tip 1/2] [BUGFIX] kprobes/x86: Prohibit probing on debug_stack_* |
| |
* Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> -int is_debug_stack(unsigned long addr) > +int __kprobes is_debug_stack(unsigned long addr)
_Please_ add a __noprobes method, for new annotations.
Naming it '__kprobes' is actively confusing, as it suggests that the function is somehow positively involved with kprobes support. Instead it should the noinline/notrace pattern.
I complained about this before and not much happened on this front. We might not want to convert the whole kernel straight away, but for _new_ annotations there's no excuse not to name them properly. Lets phase out __kprobes, and use __noprobe from now on, okay?
Thanks,
Ingo
| |