lkml.org 
[lkml]   [2013]   [Oct]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH V2] printk/cache: Mark printk_once test variable __read_mostly
On 30/10/13 23:01, Joe Perches wrote:
> Add #include <linux/cache.h> to define __read_mostly.
>
> Convert cache.h to use uapi/linux/kernel.h instead
> of linux/kernel.h to avoid recursive #includes.
>
> Convert the ALIGN macro to __KERNEL_ALIGN.
>
> printk_once only sets the bool variable tested
> once so mark it __read_mostly.
>
> Neaten the alignment so it matches the rest of the
> pr_<level>_once #defines too.
>
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> V2: Add cache.h which was nearly always used
> indirectly via #include <some_other_file.h>,
> generally module.h
> Update cache.h to avoid recursive #include
>
> include/linux/cache.h | 4 ++--
> include/linux/printk.h | 19 ++++++++++---------
> 2 files changed, 12 insertions(+), 11 deletions(-)
>
> diff --git a/include/linux/cache.h b/include/linux/cache.h
> index 4c57065..63a1d97 100644
> --- a/include/linux/cache.h
> +++ b/include/linux/cache.h
> @@ -1,11 +1,11 @@
> #ifndef __LINUX_CACHE_H
> #define __LINUX_CACHE_H
>
> -#include <linux/kernel.h>
> +#include <uapi/linux/kernel.h>
> #include <asm/cache.h>
>
> #ifndef L1_CACHE_ALIGN
> -#define L1_CACHE_ALIGN(x) ALIGN(x, L1_CACHE_BYTES)
> +#define L1_CACHE_ALIGN(x) __KERNEL_ALIGN(x, L1_CACHE_BYTES)

I think that should be __ALIGN_KERNEL (same applies to commit message).

Otherwise this patch looks good to me and builds all Meta defconfigs fine.
Reviewed-by: James Hogan <james.hogan@imgtec.com>

Thanks
James



\
 
 \ /
  Last update: 2013-10-31 14:41    [W:0.136 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site