Messages in this thread | | | Date | Wed, 30 Oct 2013 15:25:11 +0000 | From | Mel Gorman <> | Subject | Re: [PATCH] Fix page_group_by_mobility_disabled breakage |
| |
On Fri, Oct 25, 2013 at 02:09:35PM -0400, kosaki.motohiro@gmail.com wrote: > From: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com> > > Currently, set_pageblock_migratetype screw up MIGRATE_CMA and > MIGRATE_ISOLATE if page_group_by_mobility_disabled is true. It > rewrite the argument to MIGRATE_UNMOVABLE and we lost these attribute. > > The problem was introduced commit 49255c619f (page allocator: move > check for disabled anti-fragmentation out of fastpath). So, 4 years > lived issue may mean that nobody uses page_group_by_mobility_disabled. >
Nobody uses page_group_by_mobility_disabled with CMA at least. page_group_by_mobility_disabled only kicks in automatically for small machines so it's possible the condition is very rarely encountered.
Anyway
Acked-by: Mel Gorman <mgorman@suse.de>
-- Mel Gorman SUSE Labs
| |