Messages in this thread | | | Date | Thu, 3 Oct 2013 22:07:15 +0100 | From | Matt Fleming <> | Subject | Re: [PATCH 2/6] Add shared update_fdt() function for ARM/ARM64 |
| |
On Thu, 03 Oct, at 12:28:03PM, Roy Franz wrote: > Hi Matt, > > This function is shared between ARM and ARM64, which are separate > architectures so to keep this in arch code would require it to be > duplicated for ARM/ARM64. Would moving this function to a new > "efi-stub-fdt.c" file be satisfactory? This file would just be used > the ARM and ARM64, so this would remove > the need for the top-level #ifdefs.
Fair enough, move it to drivers/firmware/efi/fdt.c - there's no need to prefix it with "efi-" (efi-pstore.c has historic baggage).
-- Matt Fleming, Intel Open Source Technology Center
| |