Messages in this thread Patch in this message | | | From | Peter Huewe <> | Subject | [PATCH 2/2] tpm/tpm_ppi: Check return value of acpi_get_name | Date | Wed, 30 Oct 2013 01:40:28 +0100 |
| |
If status = acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer); fails for whatever reason and does not return AE_OK if (strstr(buffer.pointer, context) != NULL) { does dereference a null pointer.
-> Check the return value and return the status to the caller
Found by coverity CID: 728462 Explicit null dereferenced Cc: stable@vger.kernel.org Signed-off-by: Peter Huewe <peterhuewe@gmx.de> --- drivers/char/tpm/tpm_ppi.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/char/tpm/tpm_ppi.c b/drivers/char/tpm/tpm_ppi.c index 8b2e05a..2242917 100644 --- a/drivers/char/tpm/tpm_ppi.c +++ b/drivers/char/tpm/tpm_ppi.c @@ -30,6 +30,9 @@ static acpi_status ppi_callback(acpi_handle handle, u32 level, void *context, acpi_status status; struct acpi_buffer buffer = { ACPI_ALLOCATE_BUFFER, NULL }; status = acpi_get_name(handle, ACPI_FULL_PATHNAME, &buffer); + if (ACPI_FAILURE(status)) + return status; + if (strstr(buffer.pointer, context) != NULL) { *return_value = handle; kfree(buffer.pointer); -- 1.7.8.6
| |