lkml.org 
[lkml]   [2013]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 1/2] spi: add Intel Mid SSP driver
    From
    Date
    On Tue, 2013-10-29 at 11:30 -0700, David Cohen wrote:
    > Hi Joe,
    >
    > On 10/29/2013 11:19 AM, Joe Perches wrote:
    > > On Tue, 2013-10-29 at 11:05 -0700, David Cohen wrote:
    > >> This patch adds driver for ssp spi interface on Intel Mid platform.
    > >
    > > A few simple notes:
    > >
    > > Please consider using checkpatch.
    >
    > I did and got no warnings. But haven't used --strict option.

    Interesting. I thought there was a return (foo);
    statement that should have been marked, but I didn't
    actually run checkpatch.

    static inline u32 is_rx_fifo_empty(struct ssp_drv_context *sspc)
    +{
    + return ((read_SSSR(sspc->ioaddr) & SSSR_RNE) == 0);
    +}

    This could be bool too




    \
     
     \ /
      Last update: 2013-10-29 20:41    [W:4.121 / U:0.684 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site