lkml.org 
[lkml]   [2013]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH trivial v2] ata: libata-eh: Remove unnecessary snprintf arithmetic
    Remove an unnecessary arithmetic operation from a call to snprintf, because
    the size parameter of snprintf includes the trailing null space.
    Also, initialize the buffer on definition instead of a memset call.

    Signed-off-by: Levente Kurusa <levex@linux.com>
    ---
    diff --git a/drivers/ata/libata-eh.c b/drivers/ata/libata-eh.c
    index f9476fb..b7c4146 100644
    --- a/drivers/ata/libata-eh.c
    +++ b/drivers/ata/libata-eh.c
    @@ -2394,7 +2399,7 @@ static void ata_eh_link_report(struct ata_link *link)
    struct ata_port *ap = link->ap;
    struct ata_eh_context *ehc = &link->eh_context;
    const char *frozen, *desc;
    - char tries_buf[6];
    + char tries_buf[6] = "";
    int tag, nr_failed = 0;

    if (ehc->i.flags & ATA_EHI_QUIET)
    @@ -2425,9 +2432,8 @@ static void ata_eh_link_report(struct ata_link *link)
    if (ap->pflags & ATA_PFLAG_FROZEN)
    frozen = " frozen";

    - memset(tries_buf, 0, sizeof(tries_buf));
    if (ap->eh_tries < ATA_EH_MAX_TRIES)
    - snprintf(tries_buf, sizeof(tries_buf) - 1, " t%d",
    + snprintf(tries_buf, sizeof(tries_buf), " t%d",
    ap->eh_tries);

    if (ehc->i.dev) {

    \
     
     \ /
      Last update: 2013-10-29 20:21    [W:2.296 / U:0.876 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site